Skip to content

[feat] add java client library #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Oct 22, 2025
Merged

[feat] add java client library #44

merged 32 commits into from
Oct 22, 2025

Conversation

@muir
Copy link
Collaborator

@muir muir commented Sep 24, 2025 •
edited
Loading

This adds a java library that parallels the Go and Python libraries.
Some small adjustments were made to existing code along the way.

@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 51.46089% with 515 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.09%. Comparing base (6ca7eba) to head (73dc9cd).

Files with missing lines Patch % Lines
...ava/src/main/java/com/singlestore/s2iam/S2IAM.java 48.90% 101 Missing and 39 partials ⚠️
...singlestore/s2iam/providers/azure/AzureClient.java 46.97% 55 Missing and 24 partials ⚠️
...com/singlestore/s2iam/providers/gcp/GCPClient.java 43.79% 50 Missing and 27 partials ⚠️
python/src/s2iam/api.py 46.23% 38 Missing and 12 partials ⚠️
...com/singlestore/s2iam/providers/aws/AWSClient.java 63.84% 31 Missing and 16 partials ⚠️
python/src/s2iam/gcp/__init__.py 40.54% 39 Missing and 5 partials ⚠️
python/src/s2iam/azure/__init__.py 49.23% 24 Missing and 9 partials ⚠️
.../main/java/com/singlestore/s2iam/S2IAMRequest.java 73.58% 8 Missing and 6 partials ⚠️
...m/exceptions/NoCloudProviderDetectedException.java 0.00% 10 Missing ⚠️
...a/com/singlestore/s2iam/options/WithProviders.java 0.00% 6 Missing ⚠️
... and 7 more
Additional details and impacted files 
@@             Coverage Diff              @@
##               main      #44      +/-   ##
============================================
- Coverage     66.91%   63.09%   -3.83%     
- Complexity        0       59      +59     
============================================
  Files            20       41      +21     
  Lines          2914     3921    +1007     
  Branches        149      366     +217     
============================================
+ Hits           1950     2474     +524     
- Misses          787     1142     +355     
- Partials        177      305     +128
Flag Coverage Δ
aws-negative 31.90% <25.73%> (-2.49%) ⬇️
aws-positive 42.89% <37.04%> (-2.06%) ⬇️
azure-negative 31.57% <27.89%> (-1.62%) ⬇️
azure-positive 44.19% <37.22%> (-2.48%) ⬇️
base 35.53% <ø> (ø)
gcp-negative 30.42% <25.44%> (-2.56%) ⬇️
gcp-positive 41.72% <36.38%> (-1.69%) ⬇️
go 61.56% <50.04%> (-3.71%) ⬇️
java 61.82% <50.98%> (?)
python 62.02% <50.32%> (-3.80%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@muir muir requested a review from Copilot October 15, 2025 23:52
Copilot AI reviewed Oct 15, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 54 out of 55 changed files in this pull request and generated 8 comments.

muir added 2 commits October 16, 2025 10:50
@muir
chore: apply accepted review changes (docs cleanup, fail-fast test he…
a3b9df1 
…lper, orchestrator validation, gcp rationale, builder test dedupe, detection simplification)
@muir
some cleanup
1371c51
@muir muir requested a review from Copilot October 16, 2025 19:51
Copilot AI reviewed Oct 16, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 55 out of 56 changed files in this pull request and generated 10 comments.

@muir muir marked this pull request as ready for review October 16, 2025 21:28
@muir muir requested a review from mgiannakopoulos October 16, 2025 21:28
mgiannakopoulos
mgiannakopoulos reviewed Oct 21, 2025
View reviewed changes
mgiannakopoulos
mgiannakopoulos approved these changes Oct 21, 2025
View reviewed changes
Copy link
Collaborator

@mgiannakopoulos mgiannakopoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 Ship IT!

@muir muir merged commit 170cded into main Oct 22, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@mgiannakopoulos mgiannakopoulos mgiannakopoulos approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@muir @codecov-commenter @mgiannakopoulos